Skip to content

JBTM-3803 re-enable narayana-spring-boot quickstart #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

JBTM-3803 re-enable narayana-spring-boot quickstart #489

merged 1 commit into from
Oct 22, 2025
+170 −148

Conversation

marcosgopen
Copy link
Member

https://issues.redhat.com/browse/JBTM-3803
Using dev.snowdrop dependency for narayana-spring-boot

to re-enable:

narayana-spring-boot [x]
stock-market-with-narayana-spring-boot []
camel-with-narayana-spring-boot []

@marcosgopen marcosgopen marked this pull request as draft October 9, 2025 11:09
marcosgopen
marcosgopen commented Oct 9, 2025
View reviewed changes
...spring-boot/src/main/java/org/springframework/boot/jta/narayana/DbcpXADataSourceWrapper.java
* @author <a href="mailto:[email protected]">Zheng Feng</a>
*/
@Configuration
public class DbcpXADataSourceWrapper implements XADataSourceWrapper {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted as already injected by NarayanaAutoConfiguration by dev.snowdrop

@jbosstm-bot
Copy link

Started testing this pull request: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/437/

marcosgopen
marcosgopen commented Oct 9, 2025
View reviewed changes
...spring-boot/src/main/java/org/springframework/boot/jta/narayana/DbcpXADataSourceWrapper.java
private TransactionManager tm;

@Override
public DataSource wrapDataSource(XADataSource xaDataSource) throws Exception {
Copy link
Member Author

@marcosgopen marcosgopen Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using GenericXADataSourceWrapper by dev.snowdrop instead (see https://github.com/snowdrop/narayana-spring-boot/blob/fe90db50f0b1f706565cc768fbf63eda5df0aa96/narayana-spring-boot-core/src/main/java/dev/snowdrop/boot/narayana/core/jdbc/GenericXADataSourceWrapper.java#L100)

@jbosstm-bot
Copy link

Pull passed: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/437/

@jbosstm-bot
Copy link

Started testing this pull request: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/438/

@jbosstm-bot
Copy link

Pull passed: https://jenkins-csb-narayana-ci.dno.corp.redhat.com/job/btny-pulls-narayana-quickstart/438/

@marcosgopen marcosgopen marked this pull request as ready for review October 17, 2025 09:03
tomjenkinson
tomjenkinson approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@tomjenkinson tomjenkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a Spring expert but it looks good to me, thank you @marcosgopen

@marcosgopen marcosgopen merged commit 5664513 into jbosstm:main Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomjenkinson tomjenkinson tomjenkinson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcosgopen @jbosstm-bot @tomjenkinson